Skip to content

fix: Toolbar styles with triggerless left drawer #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
georgylobko merged 1 commit into from
Dec 30, 2025
Merged

fix: Toolbar styles with triggerless left drawer #4137

georgylobko merged 1 commit into from
Dec 30, 2025

Conversation

@georgylobko
Copy link
Member

@georgylobko georgylobko commented Dec 30, 2025 •
edited
Loading

Description

Fixed visual issue on the toolbar with the triggerless left drawer.

Before:
image

After:
image

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (27dbde0) to head (f6f26c6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4137   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         869      869           
  Lines       25473    25473           
  Branches     9209     9208    -1     
=======================================
  Hits        24745    24745           
- Misses        681      722   +41     
+ Partials       47        6   -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgylobko georgylobko marked this pull request as ready for review December 30, 2025 11:49
@georgylobko georgylobko requested a review from a team as a code owner December 30, 2025 11:49
@georgylobko georgylobko requested review from SpyZzey and removed request for a team December 30, 2025 11:49
@georgylobko georgylobko added this pull request to the merge queue Dec 30, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 30, 2025
@georgylobko
fix: Toolbar styles with triggerless left drawer (#4137)
278f253
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2025
@georgylobko georgylobko added this pull request to the merge queue Dec 30, 2025
Merged via the queue into main with commit 1a05a16 Dec 30, 2025
50 checks passed
@georgylobko georgylobko deleted the fix/toolbar-with-left-drawer-styles branch December 30, 2025 13:00
ngynmt pushed a commit to ngynmt/components that referenced this pull request Jan 5, 2026
@georgylobko
fix: Toolbar styles with triggerless left drawer (cloudscape-design#4137
1fa9ff1 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avinashbot avinashbot avinashbot approved these changes

@SpyZzey SpyZzey Awaiting requested review from SpyZzey SpyZzey is a code owner automatically assigned from cloudscape-design/cloudscape-dev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgylobko @avinashbot